Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] for scroll_into_view #286

Merged

Conversation

NiklasGeier
Copy link
Contributor

The problem was that as soon as you were not logged in, you got an odoo client error when you tried to click through a wizard. Instead of setting a default value I just ignore it. In our case this works very well on Odoo 17.0+e

@NiklasGeier NiklasGeier changed the title [FIX] for scroll_into_view #275 [FIX] for scroll_into_view novacode-nl/odoo-formio#275 Aug 23, 2024
@NiklasGeier NiklasGeier changed the title [FIX] for scroll_into_view novacode-nl/odoo-formio#275 [FIX] for scroll_into_view Aug 23, 2024
@bobslee
Copy link
Member

bobslee commented Aug 23, 2024

@NiklasGeier Good catch, this indeed is a bug and your PR fixes this.

In order to accept (merge) your PR you need to sign the CLA.
https://github.com/novacode-nl/odoo-formio/wiki/Contributing-and-CLA
I assume you need the (company) CCLA ?

Please send an e-mail to [email protected] - So we'll send you the document to sign.
Thanks!

@bobslee bobslee added bug Something isn't working 17.0 labels Aug 23, 2024
@NiklasGeier
Copy link
Contributor Author

@bobslee i need the ccla, email is out

@bobslee bobslee merged commit df315fd into novacode-nl:17.0 Aug 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
17.0 bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants